search

JGCarroll / pinta-snap

MIT License
5 stars 5 forks source link

Update for Pinta 2.0 #5

Closed cameronwhite closed 2 years ago

cameronwhite commented 2 years ago

This just sets the version number and git tag for the 2.0 release (the gtk3 branch can also be merged into master after this) It looks like this was already updated for the bump to .NET 6, so there probably aren't any other changes required?

JGCarroll commented 2 years ago

Happy New Year Cameron :), and congratulations on Pinta 2!

This commit probably would work fine as is, but I'd just like to request two minor changes.

The first is simply to remove the adopt-info line, this line tells snapcraft that it should be expecting some metadata set programatically from a certain source. Since the override-pull is gone, it doesn't make sense to still have it (and this might confuse snapcraft maybe)

And the other is just to swap source-tag to source-commit, using the fullform git hash, and putting a comment on the end (#2.0), this is purely just because certain people of the community prefer referring to the specific hash rather than the tag incase of supply chain attacks, practically it makes no difference but the peace of mind is nice to have.

Otherwise I should be able to get this and the legacy package pushed pretty quickly, of course it's your package and a big release, so if you want to have the honours of pushing it from the beta branch to stable manually on the Snapcraft developer portal after Github builds it, be my guest :).

cameronwhite commented 2 years ago

Thanks! And happy new year!

Just pushed a commit with those changes. I can do the snap store stuff once it's built :)