JGRennison / OpenTTD-patches

OpenTTD - http://www.openttd.org/ - with additional patches
Other
572 stars 130 forks source link

Add an optional "(City)" in Viewport labels #579

Closed YellowOnion closed 1 year ago

YellowOnion commented 1 year ago

Motivation / Problem

I was watching Master Hellish's S10 Let's play

And noticed that City Builder Script had a ".::City::." label on the cities, and thought this would be a handy feature on every game, especially when trying to find Cities quickly (say when comparing two towns with the same resources, and wanting to know what one to invest in at a glance).

Description

Provides a "City in Label" option similar to "Population in Label" option.

I'm woobilicious on the discord.

Limitations

Needs translations.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

JGRennison commented 1 year ago

I've got no objections to this change in principle, but I'm not really keen on duplicating all the strings for each new thing that could be added to the town label. This creates unnecessary work for the translators. I'm going to look into the string handling and see if this can be handled without a large increase in the number of strings.

JGRennison commented 1 year ago

Thanks for this, I've merged it with some adjustments