search

JGRennison / OpenTTD-patches

OpenTTD - http://www.openttd.org/ - with additional patches
Other
572 stars 130 forks source link

[Clarfication/Suggestions] Some feedback / suggestion for the reserve through signal feature #630

Open Nrgte opened 8 months ago

Nrgte commented 8 months ago

Currently the reserve through signal routefinding is placed in the middle signal. However I can't think of a usecase where it's not equivalent to just remove that signal.

Instead what I'd prefer is to have the reserve through at the first signal and it will just reserve through the next X signals. That way you can set it up that the trains coming from the left side would reserve through the whole junction or stop and the trains coming from the right side would not have reserve through and can move forward and into a depot or a different route.

Maybe I'm misunderstanding something, but from my (limited) testing this would have more use cases.

JGRennison commented 8 months ago

This would be somewhat problematic to implement in a reliable way in the pathfinder. It would effectively mean that whether a signal is a waiting point or not may depend on the particular path that the pathfinder has used to get there, so the result would not be consistent for non-linear layouts.

Nrgte commented 8 months ago

Ahh I see, thanks for the explanation. I assume this is due that the pathfinding being kinda separated from the main game logic.