search

JGRennison / OpenTTD-patches

OpenTTD - http://www.openttd.org/ - with additional patches
Other
585 stars 133 forks source link

[Bug]: Mouse position is not correctly calculated in the production chain UI #681

Closed Nrgte closed 4 months ago

Nrgte commented 7 months ago

Version of OpenTTD

0.58.2

Expected result

Mouse position is accurate like it was in 0.58.1

Actual result

Mouse position is slightly higher than the mouse cursor.

Steps to reproduce

Open up the production chain window and hover over or click on a cargo type. It will show the chain for the cargo type above.

Here is an example:

grafik

I'm hovering over Vehicle Engines and it shows me the tooltip for rubber parts which are 1 above. If I click on it, shows me the chain for rubber parts as well.

The same thing works correctly in 0.58.1:

grafik

In case it's relevant. I'm using the AXIS industry set.

Thank you for your work!

JGRennison commented 7 months ago

Thanks, I've forwarded this upstream as: https://github.com/OpenTTD/OpenTTD/issues/12465

Nrgte commented 7 months ago

If I may add a suggestion: I think it would be good if you increased the version number by a minor version rather than a patch version if you're doing an upstream merge. (I'm assuming that the merge happened between 0.58.1 and 0.58.2 since there were quite some severe bugs in 0.58.2). :)

Thanks again!

JGRennison commented 7 months ago

Almost every release has at least something merged from upstream

Nrgte commented 7 months ago

Ahh I see. I thought you'd only merge after larger upstream updates. Thanks for the clarification.

JGRennison commented 4 months ago

Should be fixed in recent releases