search

JGeek00 / droid-hole

Pi-hole® client made with Flutter
Apache License 2.0
135 stars 11 forks source link

Base path #6

Closed jvandenbroek closed 1 year ago

jvandenbroek commented 1 year ago

Could you add an option to provide a base path? E.g. https://domain/pihole. Thanks!

JGeek00 commented 1 year ago

I don't understand what is your request and what do you mean with base path. Are you asking for connecting to your pihole using a domain?

jvandenbroek commented 1 year ago

No, just an option to provide a base / sub / root path, however you want to call it :-) I've pihole running behind a reverse proxy, which means I do not access it like as http://IP/admin but https://ip/pihole/admin instead.

Whoops closed it, big fingers.

JGeek00 commented 1 year ago

The application composes the URL on this way: ${server.address}/admin/index.php. What you input on the domain/IP field is combined with what you input on the port field (if it's not empty), and then added to the rest of the URL. So in your case, if you input "ip/pihole" on the domain/IP field, leave the port field empty, and select https, the result URL will look like this: "https://ip/pihole/admin/index.php". I will update the app to support adding that /pihole after the IP/domain on that field.

JGeek00 commented 1 year ago

I have published a new update on Google Play. Let me know if that works for you.

jvandenbroek commented 1 year ago

Excellent, it works as expected! Thanks!