Rubric and Summary - Githubissues

ulisigi commented 5 years ago

Rubric Score

Criteria 1: HTML and CSS Linking

Score Level: 4/4
Comment(s): HTML file contains a valid link to the correct CSS file.

Criteria 2: Implementation of Design Specification and Content

Score Level: 1/4
Comment(s): There are content or style omissions from the design specification in every section (header, brushes, frame, paint) of the page.

Criteria 3: HTML Elements and Content

Score Level: 4/4
Comment(s): Content: HTML content matches the design specification

Tags: The tags in the HTML are used for their intended purpose (

for paragraphs, for headers, etc.)

Criteria 4: CSS Selectors and Syntax

Score Level: 3/4
Comment(s): Syntax: No more than one incorrect selector (id, class, element type). No more than one rule set is invalid CSS.

Overall Score: 12/16

Your project Meets Expectations - good job! Watch out for typos and how they affect your styling. If your editor doesn't highlight errors by default, you can install extensions or packages to do this for you. As your projects become larger and more complex, I recommend using comments in your HTML and CSS files to help keep them readable and organized. Also, I recommend using semantic elements in your HTML for readability and improved accessibility of your site. Here's a reference for semantic elements: https://developer.mozilla.org/en-US/docs/Web/HTML/Element Here's an article about semantics and accessibility: https://24ways.org/2017/accessibility-through-semantic-html/

Your next project to be submitted for review will be Tea Cozy at the end of Unit 4. Be aware of implicit styling and consider balance in the design and layout of the mock as your build the project so you'll better match the redline document. Overall, well done on your first submitted project. Only a few minor tweaks and you would have matched the design specification perfectly. Keep up the good work, and happy coding!

JGillin33 commented 5 years ago

Thanks so much. I see the errors now. I will read through the linked articles. I appreciate the feedback.