Rewrite server in Typescript

JH1ller / csgo-stratbook

Web & Desktop App to collaboratively manage csgo team playbook

https://stratbook.pro

GNU General Public License v3.0

15 stars 10 forks source link

Rewrite server in Typescript #15

Open JH1ller opened 3 years ago

JH1ller commented 3 years ago

The backend is currently written in the express framework with vanilla js. To prevent bugs and runtime errors the plan is to rewrite the whole thing in the fastify framework with typescript

[ ] Core migration
[x] Authentication/Authorization
[x] Database
[x] Frontend Migration
[ ] Existing Data Migration

Changes

[x] change JWT to cookie based session handling
[x] add captcha bot check to registration (Evaluate https://www.mtcaptcha.com/ as an recaptcha replacement)
[x] checkout if we need to create indices on lookup eg. email fields inside our schemas

Runtime improvements:

[x] Delegate compression, rate limiting, SSL handling/redirect to reverse proxy (compression, express-rate-limit)
[x] Static file serving through reverse proxy

Docker improvements:

[x] Evaluate minio support for S3 emulation (required for unit testing).

Proposes

[ ] Add video redirection prompt so users know they are leaving stratbook.
[x] Rewrite emails with mjml https://mjml.io/

ItsClemi commented 3 years ago

Breaking schema changes

player schema

renamed confirmed to mailConfirmed
renamed name to userName

Breaking model changes.

GET: /users/ renamed response property _id to id, renamed name to userName, renamed confirmed to mailConfirmed

Model discussion:

Is the active field of POST: /strats-model still in use?

JH1ller commented 3 years ago

Breaking schema changes

player schema

renamed confirmed to mailConfirmed

We will need some sort of upgrade/migration strategy to make existing users compatible. On an unrelated note: we could even think about api versioning -> /api/v1