Update indicator padding calc

JHBitencourt / timeline_tile

A package to help build customisable timelines in Flutter.

https://pub.dev/packages/timeline_tile

MIT License

743 stars 146 forks source link

Update indicator padding calc #12

Closed hysuki closed 4 years ago

hysuki commented 4 years ago

Indicator padding issue, Indicator size gets smaller as it gets closer to the edge.

Example

indicatorStyle: IndicatorStyle(
        width: 30,
        height: 30,
        indicatorY: 0~1.0
...

indicatorY	image
0
0.5
1

JHBitencourt commented 4 years ago

Thanks for the PR. I'll give it a look soon.

JHBitencourt commented 4 years ago

I appreciate your PR, but I'm currently not accepting this one.

It does not address and fix all the situations when calculating the indicator padding. In order to support horizontal timelines I refactored this calculation, as you can see here: https://github.com/JHBitencourt/timeline_tile/pull/16

Thanks! :D