search

JHBitencourt / timeline_tile

A package to help build customisable timelines in Flutter.
https://pub.dev/packages/timeline_tile
MIT License
743 stars 146 forks source link

Make iconStyle a widget #6

Closed chitgoks closed 4 years ago

chitgoks commented 4 years ago

This way, users can have the option to even tap the icon in the indicator

or im not sure how you would do this but considering there is already an indicator property which is a widget, perhaps a callback property so that users who want to use the default indicator will be able to execute call back code when that indicator widget is clicked.

JHBitencourt commented 4 years ago

I don't think making IconStyle itself a Widget would be a good idea.

But a callback to add onTap functionality to the default indicator is definitely a good suggestion. The question is if I should ignore it when a custom indicator is provided. Considering that this custom indicator may have its own onTap callback.

JHBitencourt commented 4 years ago

Since it is basically the same subject, I'll be closing this issue and keep track on #5 .