search

JHGuitarFreak / UQM-MegaMod

A fork of The Ur-Quan Masters + HD-mod that remasters the HD graphics with a veritable smorgasbord of extra features, options, QoL improvements, and much more...
https://uqm-mods.sourceforge.net
GNU General Public License v2.0
80 stars 22 forks source link

HD: Animation bug while using SDL2 builds #25

Closed Serosis closed 3 years ago

Serosis commented 4 years ago

Seems in SDL2 the animation frames aren't clearing properly for the Earth Starbase leading to black lines around the animated frames that build up over a period of time.

image

This does not happen in either SDL1 in HD nor in SDL2 in SD so it may actually be a problem with the animation content itself.

JoshuaPettus commented 4 years ago

Yup I can confirm that this is in my linux test build I made with SDL2. Didn't notice at first as first! XD

Serosis commented 4 years ago

Definitely not the content as it's the exact same animation frames from the HD-Mod.

So something is not clearing the animation properly.

Serosis commented 4 years ago

Fixed this by remasking and tightening up the Starbase animation files. image

Serosis commented 4 years ago

Reopening this issue because it happens with the Umgah and the Shofixti as well.

Hopefully I can find a way to fix it without having to remask all the affected animation files.

EDIT:

Druuge and Arilou also have the bug.

Serosis commented 4 years ago

After talking with McMartin it seems to be a pixel transparency issue where SDL2 is having an issue with alpha transparency blending. I can easily remove all transparent pixels from affected animations but I would like to find out where SDL1 and 2 differ in this case in the code.

Serosis commented 3 years ago

After rescaling UI and most of the HD animations this is no longer an issue per se but still an issue if you want animations with half transparencies. Closing it for now since it no longer affects the MegaMod.