JHGuitarFreak / UQM-MegaMod

A fork of The Ur-Quan Masters + HD-mod that remasters the HD graphics with a veritable smorgasbord of extra features, options, QoL improvements, and much more...
https://uqm-mods.sourceforge.net
GNU General Public License v2.0
80 stars 22 forks source link

Kruzenshtern's Bugs: Gaia reverts it’s name in SIS Title to Planet I. #35

Closed Serosis closed 4 years ago

Serosis commented 4 years ago

A gentleperson named Kruzenshtern got in touch with me and sent me a lovely list of bugs that I'm entering in here so they can be tracked proper.

This is their third bug, verbatim:

After meeting the Syreen, Betelgeuse I becomes Gaia. But after telling the Syreen about Deep Children and giving them the egg case, planet name reverts back to Planet I until their quest at Organon is fully completed and player get access to Penetrator starships.

Steps to reproduce:

⦁ Go to Betelgeuse I ⦁ Meet the Syreen ⦁ Leave conversation ⦁ SIS Title now says “Gaia” ⦁ Go to Beta Copernicus I (or any shattered world) ⦁ Collect Mycon Egg Case ⦁ Learn about Deep children ⦁ Return to Syreen ⦁ Gave them info and Egg Case (Conversation ends at “LEAVE US.”) ⦁ SIS Title now says “Planet I” ⦁ Complete Syreen quest ⦁ SIS Title now says “Gaia”

Possible solution

gensyr.c/static bool GenerateSyreen_generateName(const SOLARSYS_STATE solarSys, const PLANET_DESC world). Adding condition GET_GAME_STATE(SYREEN_KNOW_ABOUT_MYCON) should do the trick. image

Sidenote: not to forget add same condition for Gaia in solarsys.c/UNICODE * GetNamedPlanetaryBody (void) image

Sidenote: IMO Syra should have same conditions.

Serosis commented 4 years ago

Fixed with commit 778168d