Hopper subsystem position/direction constants

JHS-Viking-Robotics / FRC-2022

Code for the 2022 FRC season, now written in Java

Other

2 stars 2 forks source link

Hopper subsystem position/direction constants #20

Closed derickson2402 closed 2 years ago

derickson2402 commented 3 years ago

Edit: Use Constants.java rather than enum

Create an enum in the Hopper subsystem class for calling pre-determined heights, mainly:

Up
Down
Dispense

and another enum for the intake, mainly:

In
Out
Neutral (off)
Hold (apply very low current inwards)

derickson2402 commented 3 years ago

Editing description, we should use Constants.java rather than an enum for consistency and for importing to RobotContainer and command classes.

See PR #21 for more info.

derickson2402 commented 3 years ago

Closed #21 and moved the discussion here.

I am currently writing code to use an enum for the different modes, and then NetworkTables and Constants.java to supply the actual values.

derickson2402 commented 3 years ago

This issue is resolved with 8671943, with the NetworkTables implementation. However, if this introduces problems (see #30), then this issue may need to be revisited.