PID - Discuss moving PID launch code to rov_control package

JHSRobo / ROSbasic

https://jhsrobo.github.io/releasepage/

5 stars 0 forks source link

PID - Discuss moving PID launch code to rov_control package #135

Open Michael-Equi opened 5 years ago

Michael-Equi commented 5 years ago

For consistency we should probably put the PID code in the new rov_control package in the odom branch.

CallMeJai commented 5 years ago

I don't know much about ROS best practices so if you think the pid.launch file should be moved, I'm down. I do want to learn more about the odom branch:

Is odom being merged into development?
Should vector-drive-pids just be merged into odom and then deleted or should it stay separate?

Michael-Equi commented 5 years ago

Odom should probably be merged into the PIDs branch or vise versa to avoid screwing with the merger on the development branch

CallMeJai commented 5 years ago

I'll keep merging Odom into pids since it'll be necessary for the pids to work well.

aldenparker commented 5 years ago

Improper naming.