[Bug]: Call to Air Pollution datas

[DuboisPa]

Contact Details

squiplanche@free.fr

What happened?

on an ESP32 (3.03 library) using OpenWeatherOneCall to request only Current weather data, the line 79 OpenWeatherOneCall::createAQ(384); in OpenWeatherOneCall.cpp disallows the call to line 84 int error_code = OpenWeatherOneCall::createCurrent(SIZE_CAPACITY);

Current weather data are always empty.

Parameters are

// OpenWeatherOneCall variables // For Latitude and Longitude Location setting if used float myLATITUDE = 49.9; // location in decimal coordinates float myLONGITUDE = 2.3; // For City ID Location setting if used int myCITYID = 3037854; //<----- Amiens,FR 3037854 ou 6455273

int myUNITS = METRIC; //<----- METRIC, IMPERIAL, KELVIN (IMPERIAL is default) // Can't get current and historical at the same time int myHISTORY = 0; //<-----Only required for historical data up to 5 days // See manual for excludes, only CURRENT Data allows 1,000,000 calls a month int myEXCLUDES = EXCL_D + EXCL_H + EXCL_M + EXCL_A; //<-----0 Excludes is default

the usage is OWOC.parseWeather(); if (OWOC.current) { pp = OWOC.current->pressure; }

Version

3.1.5 (Default)

What browsers are you seeing the problem on?

No response

Relevant log output

No response

Code of Conduct

• [X] I agree to follow this project's Code of Conduct

[JHershey69]

Can you update to current version 3.3.1? Let me know the result.

[JHershey69]

No response, closing this issue.

[DuboisPa]

sorry, answered by mail

I'm using 3.3.1 version=3.3.1

Github doesn't allow this version number when reporting a bug (or i'm wrong)

[JHershey69]

Thank you. May I see the sketch you have uploaded to the ESP32 please? You can remove any sensitive passwords from the WIFI information.

On Tue, Jul 23, 2024 at 1:37 AM DuboisPa @.***> wrote:

sorry, answered by mail

I'm using 3.3.1 version=3.3.1

Github doesn't allow this version number when reporting a bug (or i'm wrong)

— Reply to this email directly, view it on GitHub https://github.com/JHershey69/OpenWeatherOneCall/issues/52#issuecomment-2244291915, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOQWBR7Z3DD74FJ7S7EC3E3ZNXTX3AVCNFSM6AAAAABLDAJ6VKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBUGI4TCOJRGU . You are receiving this because you modified the open/close state.Message ID: @.***>

[DuboisPa]

Sensitive information are not in the file. An external file is missing, containing some html and js. not interesting.

Parameters are at lines 78-90 Initialization are at lines 260-274 Usage are at lines 359-373 and 376-384

https://pastebin.com/Tk5Ygdjb

Sorry to supply this code by an external site, but I'm not a regular user on Github and I don't know how to do

[JHershey69]

line 86:

1. int myHISTORY = 0; //<-----Only required for historical data up to 5 days

• SHOULD READ*

  1. int myHISTORY = NULL; //<-----Only required for historical data up to 5 days

In this context 0 is not NULL, and I believe you are trying to tell the program to get ZERO days of historical weather and it is ignoring CURRENT.

Let me know how that works.

THank you.

On Tue, Jul 23, 2024 at 11:37 AM DuboisPa @.***> wrote:

Sensitive information are not in the file. An external file is missing, containing some html and js. not interesting.

Parameters are at lines 78-90 Initialization are at lines 260-274 Usage are at lines 359-373 and 376-384

https://pastebin.com/Tk5Ygdjb

Sorry to supply this code by an external site, but I'm not a regular user on Github and I don't know how to do

— Reply to this email directly, view it on GitHub https://github.com/JHershey69/OpenWeatherOneCall/issues/52#issuecomment-2245585988, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOQWBR7CXESDRDQELX2FD4TZNZ2E7AVCNFSM6AAAAABLDAJ6VKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBVGU4DKOJYHA . You are receiving this because you modified the open/close state.Message ID: @.***>

[DuboisPa]

That's OK with int myHistory = NULL;

it's funny to know it's also working by commenting OpenWeatherOneCall::createAQ(384); in OpenWeatherOneCall.cpp with int myHistory=0;

Can be closed.

Thanks

[JHershey69]

To be clear, changing to NULL solved your issue?

On Tue, Jul 23, 2024 at 12:29 PM DuboisPa @.***> wrote:

That's OK with int myHistory = NULL;

it's funny to know it's also working by commenting OpenWeatherOneCall::createAQ(384); in OpenWeatherOneCall.cpp with int myHistory=0;

Can be closed.

Thanks

— Reply to this email directly, view it on GitHub https://github.com/JHershey69/OpenWeatherOneCall/issues/52#issuecomment-2245701757, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOQWBR3IKAIVBNDU2IJXRKDZN2AGRAVCNFSM6AAAAABLDAJ6VKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBVG4YDCNZVG4 . You are receiving this because you modified the open/close state.Message ID: @.***>

[DuboisPa]

Yes, changing to NULL resolved the problem. But i don't understand why the problem is also solved when myHistory is 0 and the call to OpenWeatherOneCall::createAQ(384); is commented. Is there some hidden interaction between myHistory and AirPollution ?

[JHershey69]

As far as I know Air Quality is part of Current Weather and not part of Historical.data. I'll have a look at OpenWeatherMap and see if they might have changed their API recently. I'm happy this has at least solved your issue for now. I will keep you posted.

On Wed, Jul 24, 2024 at 4:21 AM DuboisPa @.***> wrote:

Yes, changing to NULL resolved the problem. But i don't understand why the problem is also solved when myHistory is 0 and the call to OpenWeatherOneCall::createAQ(384); is commented. Is there some hidden interaction between myHistory and AirPollution ?

— Reply to this email directly, view it on GitHub https://github.com/JHershey69/OpenWeatherOneCall/issues/52#issuecomment-2247199019, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOQWBR3EFOOBXUIGI2GOBHLZN5PY5AVCNFSM6AAAAABLDAJ6VKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBXGE4TSMBRHE . You are receiving this because you modified the open/close state.Message ID: @.***>

[JHershey69]

I just went and had a look at OpenWeatherMap and there is a separate API call for historical Air Quality. My latest library version only does current AQ. I will work on an upgrade to include historical. Thanks for the heads up on this.

Jessica

On Wed, Jul 24, 2024 at 4:21 AM DuboisPa @.***> wrote:

Yes, changing to NULL resolved the problem. But i don't understand why the problem is also solved when myHistory is 0 and the call to OpenWeatherOneCall::createAQ(384); is commented. Is there some hidden interaction between myHistory and AirPollution ?

— Reply to this email directly, view it on GitHub https://github.com/JHershey69/OpenWeatherOneCall/issues/52#issuecomment-2247199019, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOQWBR3EFOOBXUIGI2GOBHLZN5PY5AVCNFSM6AAAAABLDAJ6VKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBXGE4TSMBRHE . You are receiving this because you modified the open/close state.Message ID: @.***>

[DuboisPa]

Thanks to you.

I'm using your library for this ESP32 program