JHumphreys91 / delaboratory

Automatically exported from code.google.com/p/delaboratory
GNU General Public License v3.0
0 stars 0 forks source link

Suggestion: Allow User to Select Which Layer to Delete #47

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Currently, it appears Delaboratory allows the user to delete the top layer 
only.  However, I think it would be very convenient if the user could specify 
which layer(s) to delete.  It would make re-editing easier if that was possible.

Thanks.

Original issue reported on code.google.com by sbre...@gmail.com on 30 Jul 2012 at 11:48

GoogleCodeExporter commented 8 years ago
It's not possible. 

By design layers are on layer stack, not layer list. You can't modify middle of 
the stack, only its top. 

The reason for that is assumption: layer n can depend on any layer from 0 to 
n-1, so if you remove any layer it depends - the result may be undefined. For 
instance, what should happen if you remove conversion layer? How can LAB curves 
works when you remove LAB conversion?

If you want to disable action, just set its opacity to 0.0 or disable channels 
in it.

Original comment by jacekpop...@gmail.com on 31 Jul 2012 at 11:44

GoogleCodeExporter commented 8 years ago
Thanks Jacek.  I see the issue. And setting the opacity is a work around that 
provides for the same outcome.

Just curious though.  Wouldn't an implementation that constrains the deletion 
of a conversion layer unless all filters that depend on the conversion are 
removed solve that problem?  Perhaps that is more coding than it is worth.  
But, just out of curiosity, I was wondering if that would be a workable 
approach to the issue you raised. 

Original comment by sbre...@gmail.com on 31 Jul 2012 at 1:56

GoogleCodeExporter commented 8 years ago
Yes it can be done, but please notice KISS principle. I tried to design 
everything to be simple, by allowing such steps complexity appears. And it 
leads to unstability, bugs and problems. 

Original comment by jacekpop...@gmail.com on 31 Jul 2012 at 2:10

GoogleCodeExporter commented 8 years ago
OK...so it looks like we can KISS this one goodnight!

Original comment by sbre...@gmail.com on 31 Jul 2012 at 9:47