search

JI511 / Personal_Fitness

Personal Python project to improve skills and explore different libraries. Open to any and all contributions. Using a local database with sqlite3 to learn SQL.
MIT License
0 stars 0 forks source link

Pr/54 Updated branch #55

Closed JI511 closed 5 years ago

mdamonconnolly commented 5 years ago

I'm not sure what I'm supposed to do, it says it has no conflict with base and therefore should work, so I just clicked "Approve changes", is that all I need to do?

JI511 commented 5 years ago

I just wanted you to look at what I changed on your branch to make sure you understood the reasoning behind everything. Specifically at commit 5. The no conflicts is referring to the 'master' branch that will contain these PR changes once merged. Hopefully that clears it up?

mdamonconnolly commented 5 years ago

Yep! I read your changes and am still studying the rest of the codebase too! It's a bit confusing trying to figure out what is being passed to db_api functions, but breaking it down line by line and putting print statements is helping me a little. Thanks for making the effort to help me learn! It's extremely valuable to me!

JI511 commented 5 years ago

No problem, teaching is also a great way for me to learn. Programming can be very daunting but there is no other way to learn than by just doing it!

mdamonconnolly commented 5 years ago

Should the merged branches like this one be closed to prevent repo pollution?

JI511 commented 5 years ago

Yes probably. I will try to start doing this.