search

JIITODC / bot

JIITODC's very own telegram bot!
MIT License
6 stars 10 forks source link

Basic structure is ready. #1

Closed karandevtyagi closed 3 years ago

rexagod commented 4 years ago

Nice work! I think we should work a bit more on this pull request and add some tests to verify these features in the future. Then we should be good to merge. I'll write up the tests, although we do need to host this bot somewhere before we can test this. Heroku maybe?

karandevtyagi commented 4 years ago

Heroku will be good. JODC has a heroku account.

rexagod commented 4 years ago

Cool, let's do that! 👍🏻

rexagod commented 4 years ago

Maybe we can get more people involved here from the community and divide some of these peripheral tasks among them?

aayushmau5 commented 4 years ago

Made some changes to the PR, so you don't have to write onSomeCommand(bot) for every command you make. I'm using 'fs' module, which will automatically import and run all the files present in 'command' directory. You have to make some changes to 'commands.js' files also in order to make this work. My only concern is that, if it will work on heroku or not.

rexagod commented 4 years ago

@aayushmau5 It should. I assume you are importing a json for this? Also, can you push that on your fork so we can check it out?

Ps. This should come in handy: https://www.npmjs.com/package/babel-plugin-inline-json-import

aayushmau5 commented 4 years ago

https://github.com/aayushmau5/bot Here's the fork. Let me see your suggestion also.Thanks.

rexagod commented 4 years ago

LGTM. Can you deploy your fork on your local and check whether it's working as intended?

aayushmau5 commented 4 years ago

Yup. It is working on my local machine. Should i deploy it using heroku and check ?

rexagod commented 4 years ago

We do have to deploy this to heroku anyway, for every time a PR comes through (we'll write a workflow for that soon) we'll have to mock calls for testing if everything is working fine, so go ahead! 👍🏻