search

JIITODC / loadbalancer

Toy container-aware loadBalancer in Go
14 stars 12 forks source link

Add workflows for running gofmt and golint in PRs #10

Open DelusionalOptimist opened 2 years ago

DelusionalOptimist commented 2 years ago

See #7

PankhudiB commented 2 years ago

Hello @DelusionalOptimist , I would like to pick this up.

arvindpunk commented 2 years ago

Could also add static-check while we're at it, helps with enforcing a standardized style for writing Go code.

DelusionalOptimist commented 2 years ago

Could also add static-check while we're at it, helps with enforcing a standardized style for writing Go code.

Agreed :heavy_check_mark:

Sure @PankhudiB, go ahead!

DelusionalOptimist commented 2 years ago

Hey @PankhudiB, how's the progress on this?

PankhudiB commented 2 years ago

Hey, Sorry to let you know but I am out sick since last couple of days. As much as I want to work on this I don't think I ll be able to recover soon. You can unassign me from this issue. :|

elle-Bee commented 1 year ago

Hey @DelusionalOptimist should I make the gofmt and golint operations in the build file itself or should I make seperate yaml files for them?

DelusionalOptimist commented 1 year ago

@elle-Bee feel free to create new files. It'll be convenient to have formatting/linting related workflows and build/tests separate.