JJ-8 / CTFNote

CTFNote is a collaborative tool aiming to help CTF teams to organise their work. This tool helps making notes during CTFs, so you can track your CTF notes at a later time. This is similar to the CTF pad seen in one of the video's of Liveoverflow.
GNU General Public License v3.0
9 stars 2 forks source link

API: honour DB_HOST and DB_PORT #77

Closed JJ-8 closed 5 months ago

JJ-8 commented 5 months ago

API needs to wait for the database to be up before starting.

We do not know how long it takes: just because the container is started doesn't mean that Postgres is ready. The workaround is to use a small script (start.sh) that waits until a connection to the database can be done before passing the execution to yarn.

The Dockerfile contains hardcoded values for the database's hostname and ports, but there is no guarantee that these values are always the same. This is especially true when trying to deploy CTFNote with a previously-existing database.

This commit removes the hardcoded values and replaces them with DB_HOST/DB_PORT.

Upstream commit: https://github.com/TFNS/CTFNote/pull/235/commits/9606303fe489f8e62451807f47d6f8b2ee5ba18e Upstream PR: https://github.com/TFNS/CTFNote/pull/235