Closed ApoorvGuptaAi closed 8 months ago
Example run on private repo:
Make action compatible with private repos.
* Switches to the latest github actions package and API. * Use octokit rest API interface to get PR diff (works for private repos too).
Wow, amazing. Thanks a lot. I need some time to check it out, even to understand it properly. Stick around, don't go far, and again, thanks a lot.
Wow, amazing. Thanks a lot. I need some time to check it out, even to understand it properly. Stick around, don't go far, and again, thanks a lot.
Couple of things to look out for:
Wow, amazing. Thanks a lot. I need some time to check it out, even to understand it properly. Stick around, don't go far, and again, thanks a lot.
Couple of things to look out for:
* Havent tested the waivedUser functionality, specifically if non-"User" type users should be checked.
That was one of my questions, probably something should be conveyed to the user in that case, but so far I didn't know such kind of users existed... Might be worth the while a separate PR, maybe, although what is there so far looks great.
* Tested on small PRs on private repos, I dont know if the new diff API has any limitations on size
In diff size, you mean? At any rate, maybe add a caveat in the documentation?
Also, waivedUsers is not working. I have to get around to it since summer #106
Have responded to and fixed everything.
@JJ Havent tested the latest set of changes, is there some way to test it out?
Just the basics, I just approved running them. I don't have time ATM but I would say all looks good... Thanks!
Just confirmed itsworking, please go ahead and merge.
Make action compatible with private repos.
[x] Unit tests run and pass.