JJ / github-pr-contains-action

Action that checks whether the body or diff in a PR contains a certain word.

MIT License

29 stars 33 forks source link

fix: env variable is too long #120

Closed v1v closed 5 months ago

v1v commented 5 months ago

breaking change

Pull Request Title [Delete this and put your own]

[ ] Check this box.

What this PR is about

Remove env variable that cannot be that long.

Closes https://github.com/JJ/github-pr-contains-action/issues/119

JJ commented 5 months ago

OK, I get what you're trying to do here, but it's a breaking change so we have to take it in stride. If possible, I would like to see an issue that explains what's happening to see if we can come up with a better solution; if you can't; or won't, do that, I would rather have the variable value substituted by an invalid string, pointing it to other ways of obtaining the same value.

v1v commented 5 months ago

I added some details in https://github.com/JJ/github-pr-contains-action/issues/119#issuecomment-1946138011

JJ commented 5 months ago

Thanks! It will go in the next release, available soonish.