Merge user_login and user_profile to user_account

JJCSA / backend

0 stars 1 forks source link

Merge user_login and user_profile to user_account #43

Closed shah-tejas closed 3 years ago

shah-tejas commented 3 years ago

Description

Merge user_login and user_profile to 1 table called user_account

Issue

Fixes #41

Checklist

[x] I have commented my code in hard-to-understand areas
[x] I have created relevant Unit Tests for the feature I implemented
[x] I have pulled and merged the latest code and resolved all merge conflicts
[x] I have added someone to review this PR, and informed the team on Slack

shah-tejas commented 3 years ago

Why they are merged? I might have missed the meeting when this was discussed

Yes! These were 2 different tables only because we were planning to do Authentication by ourselves, using user_login table for that. However, since we are using Keycloak now, it is better to have just 1 User table. Also, makes it easier w.r.t. frontend.

shah-tejas commented 3 years ago

Also @dishanks9 I think it is okay if you do not review the whole code, it is a huge change to review! I tested most of the APIs after this change, it seemed to work fine. Since there is not much development done yet, this should not affect much.