JK3Y / NPS-Browser-macOS

macOS version of NPS Browser
The Unlicense
195 stars 22 forks source link

Concurrent Downloads setting is broken #39

Open einsteinx2 opened 6 years ago

einsteinx2 commented 6 years ago

I'm using the latest release 1.4.2 (8).

It seems that this setting is not working correctly. With the default of 2 it will keep starting any new file I queue up, though after adding a bunch it seemed to start actually queueing them after like 6 or so (I don't remember exactly). Setting it to 1 allows more than one as well.

I was going to just fix it and make a PR, but ran into some issues with CocoaPods and have to get back to my real job :)

If I have a minute tonight I'll see if I can fix it real quick, or at least provide more info on what the root cause may be.

JK3Y commented 6 years ago

What version of mac OS are you using? I'll take a look at my code today and try to fix this. You're more than welcome to become a contributor to this project! I've done my best to make the code as readable as possible, if you run into any problems with the project I can try my best to help out.

einsteinx2 commented 6 years ago

I'm on the latest mojave beta, so totally possible it's related but I haven't really had any issues with any other software (amazingly for a beta). I did actually take a look at the code and was just going to submit PRs instead of issues, but I'm slammed with work right now. In a couple weeks I'll have more time, so I can take a look then but figured I'd make issues so I don't forget.

JK3Y commented 6 years ago

@einsteinx2 Awesome, sounds good! I may have this problem fixed by then. It always seems like I find all the bugs then i suddenly get issues reported to me, so there may be work for you when you've got some off time. :)

JK3Y commented 6 years ago

I wasn't able to get this fixed in the latest release v1.4.3, but I'll keep plugging away at it. i think it's because the Alamofire request is created before adding to the queue. This was working for me before, so more research is needed.