search

JK3Y / NPS-Browser-macOS

macOS version of NPS Browser
The Unlicense
183 stars 21 forks source link

Cropped preference window #6

Closed dhondup2 closed 6 years ago

dhondup2 commented 6 years ago

When I first launched the app the preferences window was working correctly but now it's cropped. I attached a screenshot of how it looks like.

screen shot 2018-06-22 at 6 41 32 pm
JK3Y commented 6 years ago

I'm unable to duplicate this issue, I even downloaded the release you're using. I'll rework the constraints on the Preferences window and see if that fixes the problem.

Does restarting the app fix the window? I've gone through all of the display resolutions on my macbook pro and the Preferences window stays at the correct width.

RaphaelDDL commented 6 years ago

Just to help, also happens to me, even before 1.2.2 (before you removed Swift from the name)

image

Few versions before, however, I was able to resize it by clicking on the lower right corner. Latest seems it's fixed.

dhondup2 commented 6 years ago

Uninstalling the app with AppCleaner and copying the app again seems to have fixed the problem. However, choosing the location for download seem to make the issue appear again.

JK3Y commented 6 years ago

Huh, it's still not happening for me. I've reworked the preferences window constraints and it should have (hopefully) fixed that problem. There's a few more features I want to add before pushing out a new release but if you have XCode you can compile the latest commit. If you do, could you let me know if it works?

JK3Y commented 6 years ago

Has this been fixed for you in the latest release?

RaphaelDDL commented 6 years ago

Updated to 1.2.6, no changes. One thing is that clicking on "use defaults" actually makes the window correct. image

image

Changing the location back to my folder (thus making the path longer) causes the window content to shift again.

off topic: the progress bar for fetching is looking great.

dhondup2 commented 6 years ago

The same thing is happening on my end adding the URLs also seem to change the preference window. I tried compiling the new commit and seem to have the same result.

JK3Y commented 6 years ago

@dhondup2 @RaphaelDDL I have fixed this in the latest commit https://github.com/JK3Y/NPS-Browser-macOS/commit/11cf10c311d72ba4d7ed9e0935cc8982b286b436. As soon as you mentioned the longer path I immediately knew what the problem was and was able to reproduce it. Thanks for helping debug this issue! :)