search

JKGDevs / JediKnightGalaxies

Jedi Knight Galaxies (JKG) is a multiplayer shooter with role playing elements, played out in the Star Wars universe. The project is a full conversion game modification for Jedi Knight: Jedi Academy.
https://www.jkgalaxies.net/
GNU General Public License v2.0
34 stars 12 forks source link

Fire Debuff does not interact with shields properly #270

Closed DarthFutuza closed 6 years ago

DarthFutuza commented 6 years ago

I'm not sure exactly what it SHOULD do, but it should not do one tick of damage to shield on first apply and then burn hp with shield. It should either a) Do damage to shield until shield is depleted or debuff runs out/is cancelled b) Be nullified by shields entirely as long as there is a charge

Silverfang22 commented 6 years ago

Fire means of damage should damage shields instead of ignoring them, as long as you have shields up you cannot gain the fire debuff.

DarthFutuza commented 6 years ago

Sounds good.

eezstreet commented 6 years ago

So we need some way of detecting whether shields are up, before applying the debuff, if I understand correctly?

DarthFutuza commented 6 years ago

Aye. That or just immediately put fire out if you have shield on.

Silverfang22 commented 6 years ago

It shouldn't immediately put the fire out if you have a shield on, in fact if you get lit on fire, then gain a shield it should damage your health but not the shield as it does now (?)

Perhaps even split the damage between health and shields?

eezstreet commented 6 years ago

I think it's fine as it is now, after playtesting.

DarthFutuza commented 6 years ago

Wait wut? It just flat out ignores shields though...