JKGDevs / JediKnightGalaxies

Jedi Knight Galaxies (JKG) is a multiplayer shooter with role playing elements, played out in the Star Wars universe. The project is a full conversion game modification for Jedi Knight: Jedi Academy.
https://www.jkgalaxies.net/
GNU General Public License v2.0
34 stars 12 forks source link

Wrong items being give by /give weapon #272

Open DarthFutuza opened 6 years ago

DarthFutuza commented 6 years ago

When in develop branch do the following:

/give weapon sniper_Bryar receive courier shield o.O

/give weapon sniper_Dressy receive sniper_Dressy

/give item sniper_Bryar receive sniper_Bryar

Not sure if this effects shop yet or not.

eezstreet commented 6 years ago

Sounds like file mismatch. Make sure there's no errors in the files.

DarthFutuza commented 6 years ago

Not happening for you then?

Silverfang22 commented 5 years ago

Confirmed still happening

DarthFutuza commented 5 years ago

It appears the items that are having the issues have changed a little, but its still happening. There's probably a bad item/weapon somewhere. Going to go through each one at a time till I find the problem.

DarthFutuza commented 5 years ago

Gonna start a quicklist here that I'll edit as I go through each weapon and fix/find issues.

Weapon Fixes

Give Weapon Mismatches

/give weapon [name]

bot_remote gives a pistol_suppressorPistol (which it shows in printweaponlist) Its actually a custom weapon, seekers use this? sniper_dressy gives a merr-sonn courier shield

Other Notes

Carbines

carbine_lt-60 carbine_lt-60_s both have the same exact sounds and stats, change?

carbine_lt-60_c should do slightly more damage or have some sort of other advantage, bigger clip? carbine_e-11 has stun mode as a firing mode and blaster (blaster has 120 shots in a clip of ammo, stun uses 15 of the clip) carbine_e-11_stun has flare as a firing mode, each one uses half the clip, has a stun mode that has a clip of 30, but uses 10 per clip for stun and has blaster without clips, uses 999 ammo carbine_e-11b has automatic, semi, and burst - burst is utterly slow though, plz adjust

Charge Sequences

charge_sequencer charge_laserProjector both will detonate each other (and honestly have no point in existing as seperate items) laserprojector should be a seperate item anyway, consider turning this one into a "detonator"

Chemical Weapons

Need to make new poison gas carbine chem_cr-24 works but the projectile bullet is really glitchy (especially in 3rd person chem_carbR is ridiculously overpowered

Grenades

Bacta grenades have no model or icon, also need more variants. (grenade_bacta_Antidote-e) - they also do not filter by aid type and instead are treated as weapons. rw_lemons do not have a stack.
grenade_cryoban can explode midair, but the effect is not applied in the air only on the ground, thus making an invisible deadly ice field. Edit effect to work in air?

Launchers

launcher_DC-15A is missing labels on its 3 firing modes, only the launcher mode has text launcher_E-60R ammo is probably not expensive enough, currently 45 per rocket launcher_w-90_ConcRifle is missing a model and icon, incomplete? launcher_stouker has a firing mode labeled shockpulse that has an invisible/incomplete effect (if intentional, it probably should be changed)

Mines

mine_laserTrip1has no firing mode labels, also will kill teammates if they trip the wire mine_lasertrip2 however works perfectly

Pistols

pistol_de-10_snub should have slightly faster firing rate pistol_ee-3 has missing icon and no model (probably too op as well). No cost in shop. pistol_westar-34 has missing icon and no model. It also doesn't auto assign to aci, clip is probably too. No cost in shop. pistol_l8_scope has no textures and no cost in shop, also missing scope overlay in ADS mode pistol_ACP should do something different, maybe apply poison debuff?

Repeater

repeater_DC-15A Heavy Blaster uses up too much ammo, reduce by 50% repeater_DC-15A_S has unlabelled firing modes, also reduce ammo cost like above repeater_LS-180 make firing rate slightly faster repeater_t-21_bipod has infinite ammo, make sure not in shops ever repeater_t-21increase cannon ammo consumption and reduce damage on both firing modes repeater_pulse ammo is way too expensive (12k for a refill lol wut), PB10 Pulse Power Cells

Sabers

No individual issues.

Snipers

sniper_DLT-19 and sniper_DLT-19_SB probably do too much damage sniper_DXR6 does too much damage for normal firing mode

Other

melee does not have an icon stun_baton is not sold in store

DarthFutuza commented 5 years ago

Non-Weapon Issues

Item Fixes

Give Item Mismatches

/give item [name]

The null string gives an empty item. eg: give item stun_baton does not exist as an item.

Other Notes

Shields

shield_blastech_imp (Blastech AA-45 Imperial Shield) has the same icon as shield_merrsonn_cour (Merr-Sonn Courier Shield) shield_blastech_fleet (BlastTech AA-49 Fleet Protector) and shield_bacnor_dread (Bacnor Arms Dreadnought Shield) have the same icon shield_merrsonn_ultra has same icon as merrsonn_port should edit it slightly since its a related model shield_prax_small and shield_prax_medium have the same icon, should edit it slightly

Armor

Several pieces of armor can be equipped to the same body part at once without unequipping the other.

Consumables

Seeker gives an item, but it does nothing.

DarthFutuza commented 3 years ago

Possibly this was caused by item files/wpn files not being alphabetically sorted before being loaded (thanks to Daggo that's been fixed). This needs further testing to see if it is still an issue.