JKGDevs / JediKnightGalaxies

Jedi Knight Galaxies (JKG) is a multiplayer shooter with role playing elements, played out in the Star Wars universe. The project is a full conversion game modification for Jedi Knight: Jedi Academy.
https://www.jkgalaxies.net/
GNU General Public License v2.0
34 stars 12 forks source link

Armor does not interact with player hitboxes correctly #286

Open Silverfang22 opened 6 years ago

Silverfang22 commented 6 years ago

As reported by Futuza, leg armor is providing some protection to torso, and torso armor is only providing protection to very small areas around the center of the stomach and chest.

I'm not sure the player hitbox for these areas should exist at all or it should be ignored? Maybe the player hitbox is "clipping" through the armor hitbox and is being hit more often than the armor hitbox?

Silverfang22 commented 6 years ago

Futuza's screenshots: https://i.imgur.com/Nd5COpY.png https://i.imgur.com/7bjhcSj.png https://i.imgur.com/3M1cYvc.png

DarthFutuza commented 6 years ago

Additionally leg armor is weirdly protecting non leg areas, like parts of the torso.

gyurka66 commented 3 years ago

Why does armor have a hitbox at all? wouldn't it be eaiser if armor just reduced damage for the limb it's equipped on?

DarthFutuza commented 3 years ago

Why does armor have a hitbox at all? wouldn't it be eaiser if armor just reduced damage for the limb it's equipped on?

That's actually what it does, "hitbox" is a bit of a misnomer. Its supposed to be handled the same way limb damage calculation is, but there's something off/not being applied right. That said, there might be some issues if armor doesn't actually have a hitbox, since for example if you made an armor that was really big like a hazardtrooper armor, it needs to expand/change the player's hitbox among other things.

gyurka66 commented 3 years ago

it needs to expand/change the player's hitbox among other things.

how feastible would it be to completely replace the torso / limb model with the armor. Like how the character editor changes the model?

DarthFutuza commented 3 years ago

I'll have to look at it closer as I'm not sure. It turns off the underlying model and replaces it with the armor at least visually, just not sure if it does that with hitboxes/physics etc too.