JKGDevs / JediKnightGalaxies

Jedi Knight Galaxies (JKG) is a multiplayer shooter with role playing elements, played out in the Star Wars universe. The project is a full conversion game modification for Jedi Knight: Jedi Academy.
https://www.jkgalaxies.net/
GNU General Public License v2.0
33 stars 12 forks source link

Trip Mines Not Triggering Each Other #317

Closed DarthFutuza closed 4 years ago

DarthFutuza commented 4 years ago

Trip Mines (and probably other objects/explosives), don't seem to be capable of damaging each other, so they don't set off chain reactions at the moment. I recently fixed ( 480180b ) the issue of them not being able to take damage from blaster/missile based weapons, I suspect that due to eezstreet's rewrite of how damage works via calling the debuff function this has prevented them from also interacting via damage areas.

Silverfang22 commented 4 years ago

Grenades will no longer detonate tripmines either, but launchers and blasters with splash damage will. Could this be related to the fact that they are consumables for some strange reason?

DarthFutuza commented 4 years ago

Grenades will no longer detonate tripmines either, but launchers and blasters with splash damage will. Could this be related to the fact that they are consumables for some strange reason?

I think I know what's happening, I believe its due to the way the damage for these weapons is being called. Some are using JKG_DirectDamage when they should be using JKG_DoDamage instead. I'll see if I can fix that tomorrow.

xycaleth commented 4 years ago

I think this line is the issue: https://github.com/JKGDevs/JediKnightGalaxies/blob/master/codemp/game/jkg_damageareas.cpp#L560

The grenades do damage over time with the area damage stuff, and this function only damages players and not other entities.

xycaleth commented 4 years ago

Actually the problem seems to be worse than that... various damage functions assume it's only going to damage players and ignore other entities, with various bits of code here and there to workaround previous problems 😬

xycaleth commented 4 years ago

Should be fixed in a30f192