JKISoftware / JKI-State-Machine-Editor

The JKI State Machine Editor is a tool to make it easy for developers to use the JKI State Machine. It makes common tasks extremely easy to perform and exposes the user to more “advanced” (non-obvious) JKI SM features (because they are first-class features of the Helper), as well as JKI SM best practices (since the helper can enforce them: left-justification of strings, avoiding chaining states, etc.).
BSD 3-Clause "New" or "Revised" License
17 stars 10 forks source link

JKI State Machine Explorer no longer working #105

Open marketz opened 4 years ago

marketz commented 4 years ago

I am using LV2017 0.1.f3 32 bit and using JKI state machine on my desktop programming computer. The right click menu used to work, but no longer is shown. I do occasionally take the VI and copy it to a laptop that does not have the JKI state machine installed, and sometimes change the code on the laptop . Is this breaking the JKI State Machine Explorer functions when going back to my desktop computer?

jimkring commented 4 years ago

HIi @marketz. Which JKI State Machine package(s) do you have installed. The JKI State Machine Editor package is deprecated, and you'll need to install the latest JKI State Machine package, which includes the right-click menu options.

marketz commented 4 years ago

I have uninstalled the JKI State Machine using the JKI Package Manager, and installed version 2018.0.7.45, which did not fix the problem. Is the 2018 SM compatible with LV 2017?

jimkring commented 4 years ago

Yes, JKI SM 2018 is compatible with VIPM 2013 and greater -- the right-click options should be available in 2015 and greater.

marketz commented 4 years ago

Jim, Thanks for the response. Here is a screen shot of my right click menu: image

If I drop another JKI SM on the block diagram, I can right click and see all of the options for that SM.

Do you know how I can fix this without replacing the existing SM?

jimkring commented 4 years ago

Can you show me a screenshot of the full JKI State Machine that's not working? There's something about it that's preventing the code from detecting that it's a JKI SM.

marketz commented 4 years ago

Jim, Up front let me say I am in no way proud of the code around the state machine. In my defense, I hadn't went through the training (which is why I started it Monday).
I do have experience from 8 years ago with a string state machine, but that wouldn't work with this project because of the priority of some of the things happening - this is a production machine composing of three actuators (one linear) and a scissors lift, in addition to numerous detectors. Here it is: image Thanks

jimkring commented 4 years ago

Thanks for posting your code @marketz and for the disclaimers. I think that the JKI SM Editor probably won't be able to work with this code, easily, since there have been a lot of modifications to areas of the code that the JKI SM editor expects to look a different way. If you ping me at jki.net/contact-us we could discuss ways we might be able to help you out.

marketz commented 4 years ago

Okay, I sent two messages to 'contact us', first one with cell phone number, which doesn't work since I am still at work. Second one is correct.
Are there parts that I can cut and paste to bring me back to functional JKI SM explorer? Now that I learned some of the functions, it would be nice to have it working. Thanks.

kosist commented 4 years ago

I guess it does not detect JKI SM because there are additional case structures in while loop. Once my colleague has added case structure after state machine's case structure, and SM explorer didn't work any more. And I see now many of such case structures along with state machine, so that could be a problem.

marketz commented 4 years ago

Thanks

On Thu, Apr 23, 2020 at 3:45 PM kosist notifications@github.com wrote:

I guess it does not detect JKI SM because there are additional case structures in while loop. Once my colleague has added case structure after state machine's case structure, and SM explorer didn't work any more. And I see now many of such case structures along with state machine, so that could be a problem.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JKISoftware/JKI-State-Machine-Editor/issues/105#issuecomment-618623296, or unsubscribe https://github.com/notifications/unsubscribe-auth/APJNEBZGO5NXVZV5HFUXBXDROCLEDANCNFSM4MOGLTKQ .