search

JKISoftware / JKI-State-Machine-Objects

Object-oriented framework for LabVIEW based on the JKI State Machine
BSD 3-Clause "New" or "Revised" License
95 stars 54 forks source link

Launch Dependency method is partially functional with error input. #65

Closed gcodetechnology closed 2 years ago

gcodetechnology commented 4 years ago

LaunchDependency.vi functions with an error input, but not the same as with no error input.

When there is an error input, my expectation is either that the method does not function at all or, if it does, that it functions the same way it would without an error input.

SMO - Add Dependency

francois-normandin commented 4 years ago

Hi Eric, I agree with that statement.

Note that this has been fixed in the 1.4 branch currently under review (see screenshot below), but you make me realize that it should go one step further and simply bypass all in the event of an upstream error. The diagram below is essentially a no-op, but still takes a non-zero amount of time to execute, which is suboptimal and easy to see why: image

(Some code executes in those subVIs if there is an upstream error, but the result is discarded. It will be optimized too, but should be bypassed altogether)

Thanks for catching this! Francois

francois-normandin commented 4 years ago

This is now fixed in the 1.4.0 beta release branch. https://github.com/JKISoftware/JKI-State-Machine-Objects/tree/release/1.4.0_beta