Feature Idea: Error Handler frame receives previous (error producing) state as Argument (Issue #11)

JKISoftware / JKI-State-Machine

JKI State Machine

Other

42 stars 21 forks source link

Feature Idea: Error Handler frame receives previous (error producing) state as Argument (Issue #11) #14

Closed ciozi137 closed 4 years ago

ciozi137 commented 5 years ago

Parse State Queue.vi:

Modified to save previous State & Argument. Report these as Arguments to Error Handler when an error occurs. Seems like least disruptive change to existing code.

Tests:

Test State to Error Handler.vi is a JKI State Machine that generates an error when button is clicked.
Random String.vi to add random arguments

CLAassistant commented 5 years ago

All committers have signed the CLA.

jimkring commented 4 years ago

@ciozi137 I took a look at the code. In terms of implementation, I might just use the unparsed state string line, which could include state, args, comments and whitespace. Once could still use Parse State String to parse this inside the Error Handler frame.

ciozi137 commented 4 years ago

@jimkring Your solution looks simpler. I also like that it will help debugging "State >> Argument" string errors and typos.

jimkring commented 4 years ago

This has been merged into the master branch! Thanks Patric (@ciozi137).