Include the text of the GPLv3 at the bottom of the `LICENSE.md` file

JKRT / OM.jl

A Modelica Compiler in Julia

Other

25 stars 6 forks source link

Include the text of the GPLv3 at the bottom of the `LICENSE.md` file #37

Open DilumAluthge opened 2 years ago

DilumAluthge commented 2 years ago

If you're interested in registering your Julia packages in the Julia General registry, you might notice that the AutoMerge CI check has trouble parsing the license file.

The easiest way to fix AutoMerge is to include the text of the GPLv3 license at the bottom of the LICENSE.md file. Then AutoMerge will detect the GPL license text, and the check will pass.

ViralBShah commented 2 years ago

@JKRT It was great to see you at the Modelica Conference. We were trying to figure out why we couldn't have these packages in the Julia General registry, and figured out it had to do with the Automerge system interpreting the license file correctly as an OSI approved open source license.

This PR would make it possible to register packages with the Modelica license in the Julia registry.

cc @ChrisRackauckas

JKRT commented 2 years ago

@JKRT It was great to see you at the Modelica Conference. We were trying to figure out why we couldn't have these packages in the Julia General registry, and figured out it had to do with the Automerge system interpreting the license file correctly as an OSI approved open source license.

This PR would make it possible to register packages with the Modelica license in the Julia registry.

cc @ChrisRackauckas

Hey great to hear from you @ViralBShah ! Sorry for a late reply I have been busy with several things...

I will accept this PR. However, I have to fix some issues that occured in Julia 1.8 to proceed.

Hopefully I will have some time to do it soon. However, the OpenModelica team have some other packages such as OMJulia.jl https://github.com/OpenModelica/OMJulia.jl that we would like to register

bilderbuchi commented 2 years ago

What about the BSD-new license mentioned at the top of the license file? Does that one's text also have to be added?

DilumAluthge commented 2 years ago

However, the OpenModelica team have some other packages such as OMJulia.jl https://github.com/OpenModelica/OMJulia.jl that we would like to register

I've made a similar PR for OMJulia.jl here: https://github.com/OpenModelica/OMJulia.jl/pull/70

I'm happy to make additional PRs for other packages - just let me know which packages.

DilumAluthge commented 2 years ago

What about the BSD-new license mentioned at the top of the license file? Does that one's text also have to be added?

For the purposes of registering (in the Julia General registry), it's sufficient to just include the text of the GPLv3.

JKRT commented 1 year ago

@DilumAluthge

I have yet to merge this since this package is still alpha. However, I am currently working on a private branch where I have gotten some of the components of the MSL to simulate.

However, getting certain parts of the algorithmic subset of Modelica running takes time. The current plan is to finish this work sometime during the spring, and once some significant models, such as the V6 model, are running, I will go ahead and register the packages.

The ETA is probably in about one-three months or so

DilumAluthge commented 5 months ago

Bump @JKRT