JKRhb / dtls2

A DTLS library for Dart based on OpenSSL.
MIT License
3 stars 0 forks source link

fix(dtls_client): improve error handling #70

Closed JKRhb closed 1 year ago

JKRhb commented 1 year ago

This PR should be another step towards resolving #66. If a connection attempt fails, a (slightly) better error message should now be thrown and the connection should be cleaned up properly.

There is still some work to be done in order to cover all potential sources of errors, but it should already be a significant improvement compared to the previous state of the library.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 31.81% and project coverage change: -0.34 :warning:

Comparison is base (0cf865b) 84.43% compared to head (3a7db98) 84.10%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #70 +/- ## ========================================== - Coverage 84.43% 84.10% -0.34% ========================================== Files 10 10 Lines 713 717 +4 ========================================== + Hits 602 603 +1 - Misses 111 114 +3 ``` | [Impacted Files](https://codecov.io/gh/JKRhb/dtls2/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jan+Romann) | Coverage Δ | | |---|---|---| | [lib/src/generated/ffi.dart](https://codecov.io/gh/JKRhb/dtls2/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jan+Romann#diff-bGliL3NyYy9nZW5lcmF0ZWQvZmZpLmRhcnQ=) | `86.89% <ø> (ø)` | | | [lib/src/dtls\_client.dart](https://codecov.io/gh/JKRhb/dtls2/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jan+Romann#diff-bGliL3NyYy9kdGxzX2NsaWVudC5kYXJ0) | `78.92% <31.81%> (-0.99%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jan+Romann). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jan+Romann)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.