JKRhb / dtls2

A DTLS library for Dart based on OpenSSL.
MIT License
3 stars 0 forks source link

DtlsException("Sending failed: Not connected!"). Is this exception correctly labeled ? #91

Closed Ifilehk closed 1 year ago

Ifilehk commented 1 year ago

I was thinking if this exception is correctly labeled.

Actually the connection is closed so we are no more in a dtls context so asking my self if it belongs there.

The openssl s_client behaves returning read:errno=111. Same error is thrown when trying to connect on a server that is down. https://github.com/openssl/openssl/blob/1e398bec538978b9957e69bf9e12b3c626290bea/apps/s_client.c#L3207-L3213

what is a socket error.

https://github.com/JKRhb/dtls2/blob/bb19bdfb6daf5d4643799b5451ed7f143b63a4ee/lib/src/dtls_client.dart#L521-L529

JKRhb commented 1 year ago

Hmm, so instead of a DtlsException a SocketExcption should be thrown here, right?

Ifilehk commented 1 year ago

I think so.

On Jul 15, 2023, 16:46, at 16:46, Jan Romann @.***> wrote:

Hmm, so instead of DtlsException a SocketExcption should be thrown here, right?

-- Reply to this email directly or view it on GitHub: https://github.com/JKRhb/dtls2/issues/91#issuecomment-1636805936 You are receiving this because you authored the thread.

Message ID: @.***>