JKnorr91 / ion-slide-box-tabs

An Add-On directive for the ion-slide-box, that adds tabs to the slide box, known from the Android Material Design specification
MIT License
248 stars 110 forks source link

Ionic 1.2.1 <slide-tabs-scrollable="true"> compatibility #24

Open Matheaw opened 8 years ago

Matheaw commented 8 years ago

In ionic 1.2.1 I tested the slide-tabs-scrollable="true" but the tab cannot slide when set it to true with the latest ionic version. On ionic 1.1.1, it was no issue at all.

vinimendes3 commented 8 years ago

Someone has solved this? I'm with the same issue.

didlich commented 8 years ago

+1

Matheaw commented 8 years ago

Just check with the latest ionic release 1.2.4 Copenhagen (2016-01-08), the problem seems to be solved now.

vinimendes3 commented 8 years ago

Still not working =/

vinimendes3 commented 8 years ago

@Matheaw , can you post here please a little bit of your code to see how are you implementing the ion-slide-box-tabs? I'm using Ionic release 1.2.4 and it is still not working for me =(

Matheaw commented 8 years ago
<ion-content scroll="false" >
                <ion-slide-box slide-tabs-scrollable="true" show-pager="false" ion-slide-tabs on-slide->
                    <ion-slide ion-slide-tab-label="title">
                    </ion-slide>
     </ion-slide-box>
</ion-content>

I just put like the codes above, it works for me. If still can't work, maybe you can try ionic forum or stackoverflow.

vinimendes3 commented 8 years ago

@Matheaw, thanks for your response, but still not working. After many different tests, I've noticed that it only not works in Android platform. If I debug in iOS and Web it works perfectly, but if I try on Android devices it not works. When I try on Android devices, automatically adheres "overflow: hidden" property in "element.style". Like the image bellow:

overflowhidden

Matheaw commented 8 years ago

@vinimendes3 , I think I have the same issues also, before that I haven't try on android yet. If it is the ionic issues, then you may feedback to the ionic github issues page.https://github.com/driftyco/ionic/issues. Ionic was now using the new ion-slides that support swiper http://www.idangero.us/swiper/#.Vp2l5h995o4. So at the moment, we can either roll back to version 1.1.1, waiting ionic to solve the issues or try to use the new ion-slides that support swiper features.

I saw you already find the solution by disable the overflow:hidden in "element.style"?

Matheaw commented 8 years ago

@vinimendes3 , I just found a quick fix :) in your css, you can just overwrite the ionic class...

ion-scroll{
    overflow: auto !important;
}

Until the ionic official fix is release, this is the quick solution for us now.

vinimendes3 commented 8 years ago

Amaaaaazing ! Thank you so much @Matheaw !!! Nice quick fix until some definitive solution !!!