search

JKorf / Binance.Net

A C# .netstandard client library for the Binance REST and Websocket Spot and Futures API focusing on clear usage and models
https://jkorf.github.io/Binance.Net/
MIT License
1.04k stars 427 forks source link

Change orderId type #1325

Closed AFCrio closed 9 months ago

AFCrio commented 10 months ago

Change type of orderId parameter in GetOrderAsync and CancelOrderAsync Your code has incorrect type of orderId parameter in GetOrderAsync and CancelOrderAsync in IBinanceSocketClientSpotApiTrading.
int? is specified instead of long. To see the problem you can place an order or get the real clientId from an existing order. For example, the real identifier (2712825989) cannot be converted to Int32

JKorf commented 10 months ago

Thanks for the PR, could you also update the interface to use long??

AFCrio commented 10 months ago

Yes, I'll send a corrected version in a few days.

AFCrio commented 9 months ago

I posted a fully working fix a long time ago, can you check?