search

JKorf / Binance.Net

A C# .netstandard client library for the Binance REST and Websocket Spot and Futures API focusing on clear usage and models
https://jkorf.github.io/Binance.Net/
MIT License
1.02k stars 420 forks source link

Missing parameter "autoRepayAtCancel" in methods for creating new margin orders on Binance #1329

Closed cartoonle closed 6 months ago

cartoonle commented 6 months ago

Hi!

It seems that parameter "autoRepayAtCancel" is missing in methods PlaceMarginOrderAsync(...) and PlaceMarginOCOOrderAsync(...). - Binance.Net/Binance.Net/Clients/SpotApi/BinanceRestClientSpotApiTrading.cs

https://binance-docs.github.io/apidocs/spot/en/#margin-account-new-order-trade https://binance-docs.github.io/apidocs/spot/en/#margin-account-new-oco-trade

This is very important feature and it would be great if you could add it.

Kind regards, Gregor

JKorf commented 6 months ago

I've added it in the latest version

cartoonle commented 6 months ago

It seems that parameter "autoRepayAtCancel" was only added in method PlaceMarginOrderAsync(...) but it's still missing in PlaceMarginOCOOrderAsync(...).

Kind regards, Gregor

JKorf commented 6 months ago

Ah, missed that. Added in the latest version