Refs #1386: Correct goodTillDate timestamp format to milliseconds

JKorf / Binance.Net

A C# .netstandard client library for the Binance REST and Websocket Spot and Futures API focusing on clear usage and models

https://jkorf.github.io/Binance.Net/

MIT License

1.02k stars 420 forks source link

Refs #1386: Correct goodTillDate timestamp format to milliseconds #1387

Closed roman-ivanchuk closed 1 week ago

roman-ivanchuk commented 1 week ago

This pull request fixes the issue where the goodTillDate timestamp for USD Futures limit orders was incorrectly sent in seconds, causing the order to fail. The timestamp is now correctly formatted in milliseconds.

Related Issue:

Fixes #1386

Changes:

Changed AddOptionalSeconds to AddOptionalMilliseconds in the BinanceRestClientUsdFuturesApiTrading.

Thank you for considering this pull request!

JKorf commented 1 week ago

Thanks for the detailed analysis and fix!