search

JKorf / Binance.Net

A C# .netstandard client library for the Binance REST and Websocket Spot and Futures API focusing on clear usage and models
https://jkorf.github.io/Binance.Net/
MIT License
1.02k stars 420 forks source link

Binance Client client.GetOpenOrdersAsync() and client.GetAccountInfoAsync() error #429

Closed BenDavison closed 3 years ago

BenDavison commented 3 years ago

Hi, Before the latest version of Binance dll both of these api calls worked for me. Now both fail with error "Signature for this request is not valid."

Is this a known issue?

Again I might get a chance to look myself but hoping this is already being looked at?

Ben

JKorf commented 3 years ago

I'm going to assume fixing the versions as described in #428 will fix this as well.

BenDavison commented 3 years ago

Hi,

Thanks for getting back to me so quickly, yes this did indeed fix both of the issues.

I can carry on developing.... had a bit of a break over the summer but when/if this app starts to make some profit I will be sure to send some love in your direction.

Keep up the good work

Ben

On Mon, 7 Sep 2020 at 14:45, Jan Korf notifications@github.com wrote:

I'm going to assume fixing the versions as described in #428 https://github.com/JKorf/Binance.Net/issues/428 will fix this as well.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JKorf/Binance.Net/issues/429#issuecomment-688336188, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXU7XAEYRSKMUWWIJFJM3LSETPWRANCNFSM4Q6GROCA .

BenDavison commented 3 years ago

Hi Jan,

FYI my application is listening and interacting with multiple accounts on multiple exchanges, chiefly Binance, Bittrex and Kraken. After downgrading the version of CryptoExchange.Net to get my Binance connection back up and running, the other exchanges no longer connect. It has made me question my design a little and I may consider running the exchange connections in separate services with separate dependencies but at the moment this is causing me a bit of a headache. In the short term is there a combination of Binance, Bittrex and Kraken versions that all work with the same downgraded CryptoExchange.Net without introducing other instabilities?

Many thanks

Ben

On Mon, 7 Sep 2020 at 14:59, Ben ben@boardfresh.com wrote:

Hi,

Thanks for getting back to me so quickly, yes this did indeed fix both of the issues.

I can carry on developing.... had a bit of a break over the summer but when/if this app starts to make some profit I will be sure to send some love in your direction.

Keep up the good work

Ben

On Mon, 7 Sep 2020 at 14:45, Jan Korf notifications@github.com wrote:

I'm going to assume fixing the versions as described in #428 https://github.com/JKorf/Binance.Net/issues/428 will fix this as well.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JKorf/Binance.Net/issues/429#issuecomment-688336188, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXU7XAEYRSKMUWWIJFJM3LSETPWRANCNFSM4Q6GROCA .

JKorf commented 3 years ago

I guess you should either update Binance to use the latest version (6.0.0 just pushed), or you'll have to downgrade Bittrex and Kraken one version so they work with the CryptoExchange.Net v3.0.12 version.

JKorf commented 3 years ago

Closing this since with the latest version there should be no more library miss matches

BenDavison commented 3 years ago

Thanks I will update my packages

On Wed, 9 Sep 2020, 10:57 Jan Korf, notifications@github.com wrote:

Closing this since with the latest version there should be no more library miss matches

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JKorf/Binance.Net/issues/429#issuecomment-689458985, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXU7XHLOFDIR2QUYDNOMFTSE5GPVANCNFSM4Q6GROCA .