search

JKorf / HTX.Net

A C# .netstandard client library for the Huobi REST and Websocket Spot and Swap API focusing on clear usage and models
https://jkorf.github.io/HTX.Net/
MIT License
73 stars 53 forks source link

Wrong test for eventType in SubscribeToOrderUpdatesAsync #70

Closed EricGarnier closed 3 years ago

EricGarnier commented 3 years ago

Hi JKorf, with the latest version, you changed the code in the method SubscribeToOrderUpdatesAsync line 266 from: var eventType = (string) data.Data["data"]["eventType"];

to if (data.Data["data"] == null || data.Data["eventType"] == null)

Unfortunately, the eventType is not directely under Data. I think the correct test is

          if (data.Data["data"] == null || data.Data["data"]["eventType"] == null)

Do you agree?

Eric

EricGarnier commented 3 years ago

Same player shoot again in SubscribeToOrderDetailsUpdatesAsync

Eric

JKorf commented 3 years ago

That's what you get for trying to resolve warnings I guess -_- Thanks for the report, fixed it in the latest version

EricGarnier commented 3 years ago

Hi, JKorf, the same point exists in SubscribeToOrderDetailsUpdatesAsync

Eric

JKorf commented 3 years ago

Fixed