JKorf / Kraken.Net

A C# .netstandard client library for the Kraken REST and Websocket Spot and Futures API focusing on clear usage and models
https://jkorf.github.io/Kraken.Net/
MIT License
101 stars 53 forks source link

Make all public methods of client and socketclient virtual #42

Open EpsilonD3lta opened 3 years ago

EpsilonD3lta commented 3 years ago

Feature request Make all public/protected methods of client and socketclient virtual. I would like to override some methods to customize the clients. I can make a new client, but for small changes the inheritance would be preferable.

JKorf commented 3 years ago

I'd prefer not to do this, since I would like to have the client updated with anything that users would need. Making everything overridable makes it so that a user might just fix/add something for themselfs instead of reporting/requesting it ;)

You could just fork the source and directly use it in your code if you wish.

Is there any specific thing you would like to see added/changed? Maybe I could implement it.

EpsilonD3lta commented 3 years ago

I want to make two things:

  1. Per method limiter. Sometimes I want to limit only specific calls that have lower priority

  2. I would like to create mockup client for testing or simulation with local data