search

JLBLine / WODEN

CUDA code designed to simulate interferometric data using point, Gaussian, and shapelet sky models
https://woden.readthedocs.io/en/latest/
Mozilla Public License 2.0
5 stars 0 forks source link

JOSS review issue 6 (uvfits files) #19

Closed JLBLine closed 2 years ago

JLBLine commented 2 years ago

Make the uvfits files work with pyuvdata

https://github.com/openjournals/joss-reviews/issues/3676

JLBLine commented 2 years ago

Right, with this commit 2f44420ce5c8987cf2f964d4b797d326c3459fb8, I believe I've made my uvfits files compatible with pyuvdata, in so far as I can make a pyuvdata.UVData object and read my uvfits files in with no errors.

JLBLine commented 2 years ago

@plaplant @mkolopanis I believe this has been addressed, please have a look. I'm not familiar with pyuvdata so beyond reading data in I'm not sure what tests to run

mkolopanis commented 2 years ago

pyuvdata specifically relies on any keyword defined as "required" in AIPS117 to read uvfits files. Being able to read it (with the included checks) is honestly sufficient enough proof for me at least. I have verified the functionality.

plaplant commented 2 years ago

I have not independently verified this, but it sounds like @mkolopanis has. That's proof enough for me 🙂

JLBLine commented 2 years ago

Thanks all, I'll close this now.