search

JLErvin / berry

:strawberry: A healthy, byte-sized window manager
MIT License
1.01k stars 47 forks source link

Shadows over top of window decorations #75

Closed adamchristiansen closed 4 years ago

adamchristiansen commented 4 years ago

Problem

When using a compositor (compton in my case) with shadows enabled, both the window and the window decorations have shadows, and the window shadow is on top of the decorations. This is shown in the screenshot below.

berry-shadow

Expected Behaviour

I expect something like the screenshot below taken in bspwm. I've made an extremely large border to demonstrate. There is only a single shadow for the window + decoration, and there is no "bleeding" of the shadow on to the decoration.

bspwm-shadow

Details

JLErvin commented 4 years ago

Let me see what mechanism compton uses to draw shadows. It's possible this is a product (I would guess) of the fact that berry is non-reparenting in which case this might be difficult to fix. Regardless, I'll look into it a get back to you.

JLErvin commented 4 years ago

Ah, this should be fixable using some compton settings. Consider adding the following to your compton.conf:

shadow-exclude = [
    "_NET_FRAME_EXTENTS@:c"
]

Try this and let me know if it gives you expected behavior.

adamchristiansen commented 4 years ago

This solved it. For documentation purposes if someone else is comes across this, I had

shadow-exclude = [
    "_GTK_FRAME_EXTENTS@:c"
]

in my compton.conf, but changing it to

shadow-exclude = [
    "_GTK_FRAME_EXTENTS@:c",
    "_NET_FRAME_EXTENTS@:c"
]

to use EWMH as well is more general than just GTK.

unrealapex commented 1 year ago

I get this same issue but with transparency(shadows work fine). How would I go about solving this? Would I disable shadows for the window type?