search

JLLeitschuh / ktlint-gradle

A ktlint gradle plugin
MIT License
1.47k stars 162 forks source link

fix detection of android kotlin source directories in AGP >= 7 #733

Closed wakingrufus closed 10 months ago

wakingrufus commented 11 months ago

increase maximum gradle version to 8.5 increase maximum ktlint version to 1.1.0 increase maximum kotlin version to 1.9.21 fix lint failures

fixes #702 based on work in #703

wakingrufus commented 11 months ago

Nice one 👏 I looked only at the AndroidPluginsApplier.kt class which is fine IMO. I also tested it locally on my current project and it works fine 🎉 Gradle 8.5 Kotlin version 1.9.21 AGP 8.2.0 Do you need more info regarding that?

:shipit:

Thanks for verifying! I'll give @JLLeitschuh some time to review it before merging

JLLeitschuh commented 10 months ago

Any idea why checking bashisims is failing?

wakingrufus commented 10 months ago

Any idea why checking bashisims is failing?

package resolution error in ubuntu. something similar happened before and I had to manually specify a version to fix it. Ill investigate further

JLLeitschuh commented 10 months ago

Nice work! Merged!