search

JLSteenwyk / ClipKIT

a multiple sequence alignment-trimming algorithm for accurate phylogenomic inference
https://jlsteenwyk.com/ClipKIT/
MIT License
61 stars 4 forks source link

on pinning dependency versions #16

Closed ialbert closed 2 years ago

ialbert commented 2 years ago

Some of the software pinned to a version, say click or tqdm negatively interacts with many other tools that may need newer features developed for those packages.

It is exceedingly unlikely that click or tqdm will introduce API changes that would break your code, thus I would recommend to only pin versions that have a good reason to be pinned.

For all others, you should list a minimal version number (and perhaps a maximal version number if that later turns out to be necessary).

JLSteenwyk commented 2 years ago

Hi,

Thank you for your interest in ClipKIT.

Following your suggestion, we have updated our requirements block in setup.py to be the following: ["biopython>=1.79", "numpy>=1.18", "tqdm>=4.45"]. This is now implemented in ClipKIT v1.1.6.

Thank you again!

All the best,

Jacob

ialbert commented 2 years ago

thanks Jacob, much appreciated