search

JLambertazzo / ListExtender

A JavaScript library providing interactive lists
MIT License
17 stars 29 forks source link

Batman Theme Added #20

Closed DADDY-DOUBLESHOT closed 3 years ago

DADDY-DOUBLESHOT commented 3 years ago

Hey @JLambertazzo I have added Batman theme please review my PR

JLambertazzo commented 3 years ago

Thank you for the contribution! Unfortunately there are too many changes here for me to approve. I believe the code may have been run through an auto-formatter while editing. Please make sure that the only changes when adding a theme are the one object in ListExtender.js and the one line for the button in examples.html.

Furthermore, I love the creativity of importing an svg for a list icon. However in the code's current state the only thing served with the library is the javascript code itself, so we would lost the reference to the icon. Please consider using something that doesn't need importing like the bat emoji 🦇 or anything else you can think of.

If you can make the changes above I'd love to add this theme! 🚀

DADDY-DOUBLESHOT commented 3 years ago

Hey @JLambertazzo I made those changes you requested replaced bat svg with bat emoji I hope my PR gets accepted thank you :)

JLambertazzo commented 3 years ago

Theme is looking good, unfotunately there is still too many changes to accept the merge. You can try rebasing your code from master if you'd like. You can see the changes here under the files changed tab.

DADDY-DOUBLESHOT commented 3 years ago

@JLambertazzo Rebasing master also was not able to solve conflicts hence I am creating new PR for this