Refactored store.ts to define types via namespace

JLuboff / connect-mssql-v2

MS SQL Server session store for Express Session

MIT License

5 stars 7 forks source link

Refactored store.ts to define types via namespace #33

Closed bradtaniguchi closed 3 years ago

bradtaniguchi commented 3 years ago

refactored store.ts to define namespace, fixing require('connect-mssql-v2')(session) becoming undefined

Closes #31

note I refactored the type-def following this example. This did require changing the Store variable a little, where I renamed it to the rough name of the package IE: "ConnectMSSQLV2" this name can be changed, both the variable, export and namespace all should be named the same.

PS. no hacktoberfest, but this is needed haha!

related to #32

JLuboff commented 3 years ago

Let me test this locally today, and as long as it looks good, we'll get it merged.

bradtaniguchi commented 3 years ago

@JLuboff Just to mention how I tested it, I used npm link and built out 2 mini-projects to see if things at least "ran". I still don't have a DB setup so I couldn't run a full test. However I didn't really touch the actual functionality, only the issue at hand.

The 2 mini-projects were essentially the reproduction of whats mentioned in #31 1 was a normal JS one and the second was a TS based one.