search

JLuboff / connect-mssql-v2

MS SQL Server session store for Express Session
MIT License
5 stars 7 forks source link

Update/packages #34

Closed JLuboff closed 3 years ago

JLuboff commented 3 years ago

Brad... Can you review? I've updated all packages including @types/express-session. I'm not positive what we need to do to update the original typings that you had done?

bradtaniguchi commented 3 years ago

Yea let me review/bring up the old conversation to get some context to why the types should of changed. I vaguely remembered it all dealing with how the types had () => instead of methods, when the actual implementation should be methods.

Here's the post with the most detail: https://github.com/JLuboff/connect-mssql-v2/issues/10#issuecomment-557396898