JLuboff / connect-mssql-v2

MS SQL Server session store for Express Session
MIT License
5 stars 7 forks source link

Fails Node audit (HIGH vulnerability) #61

Closed chladnefazole closed 1 year ago

chladnefazole commented 1 year ago

Describe the bug This package isn't secure, it depends on an old version of mssql which has a bunch of jsonwebtoken issues:

To Reproduce

Expected behavior Package should be updated to use mssql ^7.2.0

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context This is the only working session manager package for Microsoft SQL Server/TSQL and Node, and the vulnerabilities are significant. This could cause a lot of sites using MSSQL to become insecure as a result.

JLuboff commented 1 year ago

Hi @chladnefazole, thanks for bringing this up. npm audit fix solution would be to downgrade mssql to v7 which, I don't agree with. These vulnerabilities still exist in v9 but as one of the maintainers of mssql states, it is likely not an issue as no authentication takes place in the mssql library (see: https://github.com/tediousjs/node-mssql/issues/1451).

chladnefazole commented 1 year ago

@JLuboff Ok, understood. It's not a problem for my project but might be in some corporate setup where they don't allow any high-level vulnerabilities. But I understand that this vulnerability is not relevant to mssql.