feat: add preRemoveCallback

[bradtaniguchi]

• provides preRemoveCallback option. If provided initially, is called when a session is expired, but before the actual "delete" code. If the function returns a promise, then the callback will wait for that promise to resolve before executing the "delete" code.

• also fix some minor typos

Close #72

[bradtaniguchi]

I think I can try to add in some.

I'll have to review how to setup a full/accurate test environment on my WSL environment tho.

Might be doing the tests a little blind otherwise 😅

[bradtaniguchi]

I added a test case that follows a similar setup (but uses promises to keep things flat rather than nested callbacks), but I don't have a MSSQL database around to help run against so can't verify it.

edit let me just signup for an azure free tier account real quick to help test these changes out.... 😉

[bradtaniguchi]

Ok I got an SQL instance from Azure (thx free tier), I confirmed the tests is working/going through from my end. I also ran a smoke check against the test (instead of checking the callback was called once, I changed it to 10) and confirmed the test fails.

Also now that I have an SQL server to test against, I should be able to help debug/clean up this repo if needed, as I can finally test my changes against the test suite ^.^

[JLuboff]

Thanks for adding the test! Looks good to me (I ran locally). I will say...I don't know what I was thinking calling the variable cbed (callback ended??? I have no idea). After this PR gets merged I'll do a cleanup PR (and update deps). Glad you got SQL Server running :D I run a local docker build of SQL Server (express). Works well and only spin it up when I need to. I seem to recall pulling it down from Microsoft.

[bradtaniguchi]

Thanks for adding the test! Looks good to me (I ran locally). I will say...I don't know what I was thinking calling the variable cbed (callback ended??? I have no idea). After this PR gets merged I'll do a cleanup PR (and update deps). Glad you got SQL Server running :D I run a local docker build of SQL Server (express). Works well and only spin it up when I need to. I seem to recall pulling it down from Microsoft.

Yea I have a new laptop that I can actually work on (previously was doing some convoluted stuff on a chromebook). Getting a docker setup running could also help test this stuff out if needed 👍🏼

[JLuboff]

@bradtaniguchi Not sure if you were waiting to merge this since it was failing the checks. I cleared that (it was complaining due to line length in the README which doesn't matter). I'll have to spend a little time configuring Codacy better or removing it. However, I realized one thing. Need the version updated (minor?) in package.json and update the changelog. Can be a separate PR, this PR, or I can handle it. You decide. Will than release (I think I'll need to? I can't recall if we have you setup for permissions in npm or not).

[bradtaniguchi]

I've been meaning to get back to this, I can fix the build/bug issues in a week or so.

You can do the release, as I'm not sure how the NPM package setup is done off the top of my head.

[JLuboff]

Piggy-backed on your PR for the changelog and semver change so it can all be kept together.

[bradtaniguchi]

Thanks @JLuboff for finishing this one up 👍🏼